Background color of inactive keyboard focused list items#116
Merged
arcticicestudio merged 1 commit intodevelopfrom Mar 24, 2019
Merged
Conversation
When navigating the file explorer list with the keyboard and moving the focus to another UI component (like the editor) the background color of the selected item is colorized with the `list.inactiveFocusBackground` theme key. It has been set to `nord2` with a opacity of 80% to match the style of inactive list items that were focused without the keyboard (`list.inactiveSelectionBackground`). GH-107
svengreb
approved these changes
Mar 24, 2019
arcticicestudio
deleted the
feature/gh-107-list-inactive-keyboard-focus-background
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When navigating the file explorer list with the keyboard and moving the focus to another UI component (like the editor) the background color of the selected item is colorized with the
list.inactiveFocusBackgroundtheme key.
It has been set to
nord2with a opacity of 80% to match the style of inactive list items that were focused without the keyboard (list.inactiveSelectionBackground).Before
After
