Fix typo in vim plugin support section#172
Merged
arcticicestudio merged 2 commits intonordtheme:developfrom Jul 31, 2019
Merged
Fix typo in vim plugin support section#172arcticicestudio merged 2 commits intonordtheme:developfrom
arcticicestudio merged 2 commits intonordtheme:developfrom
Conversation
svengreb
previously approved these changes
Jul 31, 2019
arcticicestudio
approved these changes
Jul 31, 2019
Contributor
arcticicestudio
left a comment
arcticicestudio
left a comment
There was a problem hiding this comment.
Hi @impulse 👋, thanks for your contribution 👍
LGTM 😄
arcticicestudio
requested changes
Jul 31, 2019
src/components/organisms/page/ports/vim/SectionPluginSupport/SectionPluginSupport.jsx
Show resolved
Hide resolved
Contributor
Author
|
Woops hit the resolve too early. Added the missing "and" (prettier removed it with quick fix lol). Sorry couldn't test this locally due to #173 |
svengreb
approved these changes
Jul 31, 2019
arcticicestudio
approved these changes
Jul 31, 2019
Contributor
There was a problem hiding this comment.
Now we're good to go, thanks 😉
I'll write up a small summary about the problem in #173.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing additional
grbefore vim-go linkhttps://www.nordtheme.com/ports/vim