Fix(test): test on temporary directories#106
Merged
Merged
Conversation
Testing on current dir is not reproducible because it can be affected with current directory content. Test with absolute directories using `tempdir` crate
`cli` tests affect by `current_dir` anyways so run in serial using `serial_test` crate. Also, use temporary directories instead of current directory. This will prevent failed test to mess up with current directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing on current directory can be affected with current directory state and can mess up current directory when test is failed.
For example, right now, running test twice fails on second attempt because
my-site/directory still persists in current directory.Use
tempfilecrate to create temporary clean directories and automatically remove them ragardless of test failure.