Add default argument for check function in tree_insert and tree_extract #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaelanDt
approved these changes
Jul 11, 2024
Contributor
KaelanDt
left a comment
KaelanDt
left a comment
There was a problem hiding this comment.
Change makes sense, lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the default argument meant a reordering of the signature.
This is in preparation for a refactor regarding #83 by changing
TransformStateto aNamedTuple.This default
tree_insertbehaviour will be useful for updating tensor tree elements of aNamedTuplein-place, e.g.tree_insert_(state.aux, aux)