docs(shared): add sdd-gates fragment (Unit 7 prerequisite)#17
Conversation
Add shared/sdd-gates.md, the importable fragment enumerating the four per-boundary validation gate sets for the sdd-validate agent (R7.2): spec gates, architecture gates, triage gates, and implementation gates. Each gate set names the artifact it applies to and the boundary that selects it, with a severity model (Blocker, Warning, Info) where a Blocker triggers the needs-human hand-off. This fragment must land on main before sdd-validate.md can import it via the pinned-ref owner/repo/path@main form, so it ships as a standalone PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
norrietaylor
left a comment
There was a problem hiding this comment.
Verdict: Approve-equivalent. shared/sdd-gates.md is complete against R7.2, accurate, and consistent with the existing shared/*.md fragments. No blocking findings.
Reviewed against spec R7.2 (the four per-boundary gate sets), repo standards, and consistency with sibling fragments. Findings: 0 Blocker, 0 Major, 0 Minor, 2 Nit.
R7.2 completeness — pass
All four named gate sets are present and each enumerates the exact sub-items R7.2 requires:
- Spec gates (lines 26-40): acceptance criteria testable, no implementation leakage, assumptions explicit, proof artifacts present and behavioral. All four present.
- Architecture gates (lines 42-58): decision and rationale present, alternatives considered, consistent with existing
decisions/, no implementation detail masquerading as a decision. All four present. - Triage gates (lines 60-75): every spec R-ID covered by a task, dependencies form a DAG, each task single-session sized, every task has a
repo:field. All four present. - Implementation gates (lines 77-89): proof artifacts re-executed and passing, changed files within task scope, no real credentials in the diff. All three present.
The proof artifact "File: shared/sdd-gates.md contains all four named gate sets" is satisfied.
Accuracy and consistency — pass
- Severity model (Blocker / Warning / Info, lines 14-24) matches R7.3, and the "Blocker triggers
needs-human, never a failed required check" stance matches R7.4 and ADR 0001. Correct. - Boundary descriptions (
*-spec-*.md,architecture.md/decisions/**,sdd:readylabel event, other PR changes) match R7.1's boundary-resolution rules. ## Verificationsection present, consistent withsdd-interaction.mdandsdd-proof-artifacts.md.- No em dashes, ATX headings, no private literals, fenced code where applicable. Repo standards met.
Nits (non-blocking)
-
shared/sdd-gates.md:81-86— implementation gate 2 bundles two distinct checks under one gate. "Changed files within task scope" assigns Warning to an out-of-scope change and Blocker to a protected-path change. R7.2 names this as a single gate so this is acceptable, but a reader scanning gate-to-severity mapping sees one numbered gate carrying two severities. Optional: split protected-path into its own numbered gate, or add a one-line note that this gate has two severity tiers. -
PR description uses em dashes (e.g. "Spec gates — acceptance criteria..."). The file itself is clean, which is what the repo standard governs, but the PR body is a public artifact too; worth keeping consistent. Not a code defect.
Net: this fragment is ready to merge as the Unit 7 prerequisite. sdd-validate.md (PR-B) can import it via the pinned-ref @main form once this lands.
Summary
Adds
shared/sdd-gates.md, the new importable gh-aw fragment for Unit 7(the
sdd-validateagent). This is PR-A of the two-PR pattern Unit 4 used:the fragment must be on
mainbeforesdd-validate.mdcan import it via thepinned-ref
norrietaylor/spectacles/shared/sdd-gates.md@mainform, sincegh aw compileresolves@mainimports by fetching from GitHub.What it contains (R7.2)
The fragment enumerates the four per-boundary validation gate sets:
assumptions explicit, proof artifacts present and behavioral.
considered, consistent with existing
decisions/, no implementation detailmasquerading as a decision.
DAG, each task single-session sized, every task has a
repo:field.files within task scope, no real credentials in the diff.
It also defines the Blocker / Warning / Info severity model: a Blocker
triggers the
needs-humanhand-off, consistent with ADR 0001 and theadvisory-by-design stance of the spec.
Notes
shared/.sdd-validateagent that imports this) follows once this ismerged.
🤖 Generated with Claude Code