Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation for the universal search feature to clarify that users can search by register ID without specifying the scope (e.g., city) in countries where register IDs are not unique identifiers.
Key Changes:
- Corrected grammar in the universal search description
- Added footnote explaining register ID search flexibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+627
to
+628
| \* It is possible to search only for the register ID even in countries where it isn't a unique identifier (e.g., | ||
| "HRB 2000" in Germany without the city) to look for all possible matches for that register ID. |
There was a problem hiding this comment.
[nitpick] The footnote explanation is verbose and could be more concise. Consider rephrasing to: 'Register IDs can be searched without scope (e.g., city) even in countries where they aren't unique identifiers, returning all matching results.'
Suggested change
| \* It is possible to search only for the register ID even in countries where it isn't a unique identifier (e.g., | |
| "HRB 2000" in Germany without the city) to look for all possible matches for that register ID. | |
| \* Register IDs can be searched without scope (e.g., city) even in countries where they aren't unique identifiers, returning all matching results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes northdata/northdata#13774