Adding extra reload-related getters + better CanReload check#359
Merged
Conversation
…from being through even though base game wouldn't allow for reloading to happen
davidsebesta1
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds IsReloading, IsUnloading and IsReloadingOrUnloading getters to the LabApi FirearmItem wrapper.
It also adds a second change ensuring that CanReload will only return true if the firearm isn't in use (reload/unload) since base game would deny this reload.
If this change is not wanted, I think CanReload should have it's description (or also the name) changed since it doesn't reflect what it does as it only checks if the Owner of the firearm has enough ammo to perform the reload.