client/core: improve msg.Type formatting (server message handling)#3
Open
norwnd wants to merge 1 commit into
Open
client/core: improve msg.Type formatting (server message handling)#3norwnd wants to merge 1 commit into
norwnd wants to merge 1 commit into
Conversation
norwnd
force-pushed
the
client-core-imrove-error-formatting
branch
2 times, most recently
from
976dcd0 to
7e6c25c
Compare
norwnd
changed the title
norwnd
force-pushed
the
client-core-imrove-error-formatting
branch
from
7e6c25c to
ec08d3e
Compare
norwnd
force-pushed
the
master
branch
4 times, most recently
from
ad9d264 to
e298e04
Compare
norwnd
force-pushed
the
master
branch
5 times, most recently
from
f9959eb to
a66bbae
Compare
norwnd
force-pushed
the
master
branch
3 times, most recently
from
e3c487c to
333e9f6
Compare
norwnd
pushed a commit
that referenced
this pull request
Apr 16, 2026
Second T18 batch — four more items from the consolidation list.
T18#5: formatProfit duplication
- Hoisted `formatProfit(profit)` to `hooks/useFormatters.ts` and
deleted the local copies in MMPage.tsx and MMArchivesPage.tsx.
The two versions were identical modulo the result-field name
(`cls` vs `colorClass`). Standardized on `cls` at the shared
location; updated MMArchivesPage's two call sites
(`total.colorClass`, `p.colorClass`) to `total.cls` / `p.cls`.
T18#3: MM URL building consistency
- MMArchivesPage's two navigation buttons previously built URLs via
manual template strings with individual encodeURIComponent calls.
Refactored to use URLSearchParams like MMPage.tsx does. Cleaner
and handles encoding automatically (though the previous manual
encoding was also correct).
T18#8: manage peers concurrent removal race
- Added a `removingAddrs: Set<string>` state to ManagePeers. The
removePeer callback now bails out if a removal POST for the same
address is already in flight, and the Remove icon for that row
renders as a spinner while the removal is pending. Uses
functional setState so rapid-fire clicks on different rows
don't read stale closure state. Prevents the last-one-wins
refresh() race when the user double-clicks the Remove icon.
T18#2: mw-500 consolidation
- Deleted `#proposals { max-width: 500px; width: 100% }` rule from
css/proposals.scss. ProposalsPage's `<section>` now uses the
shared `mw-500` utility class (already defined in
css/utilities.scss and already used by ProposalPage). Removed
the `id="proposals"` attribute since nothing else referenced it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.