Skip to content

chore(circleci): improve build process#1104

Merged
DalderupMaurice merged 83 commits intodevelopfrom
chore/improve-circleci
Aug 23, 2019
Merged

chore(circleci): improve build process#1104
DalderupMaurice merged 83 commits intodevelopfrom
chore/improve-circleci

Conversation

@DalderupMaurice
Copy link
Copy Markdown
Member

@DalderupMaurice DalderupMaurice commented Aug 17, 2019

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 17, 2019

Codecov Report

Merging #1104 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1104   +/-   ##
========================================
  Coverage    50.79%   50.79%           
========================================
  Files          240      240           
  Lines         2063     2063           
  Branches       276      276           
========================================
  Hits          1048     1048           
  Misses         843      843           
  Partials       172      172

@DalderupMaurice DalderupMaurice added the PR: needs review Pull request label Aug 21, 2019
@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 23, 2019
@DalderupMaurice DalderupMaurice merged commit 9f5696e into develop Aug 23, 2019
@DalderupMaurice DalderupMaurice deleted the chore/improve-circleci branch August 23, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants