feat(auth): add the ability to import existing seed#1118
Merged
DalderupMaurice merged 3 commits intodevelopfrom Aug 25, 2019
Merged
feat(auth): add the ability to import existing seed#1118DalderupMaurice merged 3 commits intodevelopfrom
DalderupMaurice merged 3 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1118 +/- ##
========================================
Coverage 50.79% 50.79%
========================================
Files 240 240
Lines 2063 2063
Branches 276 276
========================================
Hits 1048 1048
Misses 843 843
Partials 172 172 |
jeroenptrs
changed the title
DalderupMaurice
changed the title
DalderupMaurice
requested changes
Aug 21, 2019
DalderupMaurice
added
PR: reviewed w/ comments
jeroenptrs
force-pushed
the
feat/import-existing-seed
branch
from
62db7bb to
76ada46
Compare
jeroenptrs
added
PR: needs review
jeroenptrs
force-pushed
the
feat/import-existing-seed
branch
from
76ada46 to
80cd815
Compare
jeroenptrs
force-pushed
the
feat/import-existing-seed
branch
from
8bfebe0 to
f10f065
Compare
DalderupMaurice
approved these changes
Aug 25, 2019
DalderupMaurice
added
PR: good to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Import existing BIP39 seed
WIP because still need to add copy
Motivation and Context
Must have functionality
How Has This Been Tested?
Imported my keys
Screenshots (if appropriate)
Types of changes
Checklist
Documentation
(Potentially a tut on how to do this? 🤷♂ )
Closing issues
Fixes #1026