Skip to content

chore(circleci): fix incorrect cache issue of circleci builds#1129

Merged
DalderupMaurice merged 4 commits intodevelopfrom
chore/fix-circleci-build
Aug 27, 2019
Merged

chore(circleci): fix incorrect cache issue of circleci builds#1129
DalderupMaurice merged 4 commits intodevelopfrom
chore/fix-circleci-build

Conversation

@DalderupMaurice
Copy link
Copy Markdown
Member

@DalderupMaurice DalderupMaurice commented Aug 27, 2019

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Aug 27, 2019
@DalderupMaurice DalderupMaurice merged commit 603e78b into develop Aug 27, 2019
@DalderupMaurice DalderupMaurice deleted the chore/fix-circleci-build branch August 27, 2019 15:38
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1129 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1129   +/-   ##
========================================
  Coverage    50.79%   50.79%           
========================================
  Files          240      240           
  Lines         2063     2063           
  Branches       276      276           
========================================
  Hits          1048     1048           
  Misses         843      843           
  Partials       172      172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant