Skip to content

feat(management): added ability to import existing wallets through a PK#1148

Merged
DalderupMaurice merged 8 commits intodevelopfrom
feature/import-wallet
Oct 6, 2019
Merged

feat(management): added ability to import existing wallets through a PK#1148
DalderupMaurice merged 8 commits intodevelopfrom
feature/import-wallet

Conversation

@DalderupMaurice
Copy link
Copy Markdown
Member

@DalderupMaurice DalderupMaurice commented Sep 15, 2019

Description

added ability to import existing wallets through a PK

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: needs review Pull request label Sep 15, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 15, 2019

Codecov Report

Merging #1148 into develop will decrease coverage by 0.56%.
The diff coverage is 15.78%.

@@             Coverage Diff             @@
##           develop    #1148      +/-   ##
===========================================
- Coverage    50.79%   50.23%   -0.57%     
===========================================
  Files          240      240              
  Lines         2063     2096      +33     
  Branches       276      280       +4     
===========================================
+ Hits          1048     1053       +5     
- Misses         843      867      +24     
- Partials       172      176       +4

@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Oct 6, 2019
@DalderupMaurice DalderupMaurice merged commit 84c24a1 into develop Oct 6, 2019
@DalderupMaurice DalderupMaurice deleted the feature/import-wallet branch October 6, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant