Skip to content

chore(wallet): add fallback random generated wallet name#1264

Merged
DalderupMaurice merged 5 commits intodevelopfrom
feature/add-wallet-label
Dec 6, 2019
Merged

chore(wallet): add fallback random generated wallet name#1264
DalderupMaurice merged 5 commits intodevelopfrom
feature/add-wallet-label

Conversation

@DalderupMaurice
Copy link
Copy Markdown
Member

@DalderupMaurice DalderupMaurice commented Dec 6, 2019

Description

Instead of auto-creating a label, it is now a fallback
Also updated the README with new labels

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 6, 2019

Codecov Report

Merging #1264 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1264   +/-   ##
========================================
  Coverage    49.85%   49.85%           
========================================
  Files          248      248           
  Lines         2122     2122           
  Branches       282      282           
========================================
  Hits          1058     1058           
  Misses         886      886           
  Partials       178      178

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Dec 6, 2019
@DalderupMaurice DalderupMaurice merged commit 5ff6b53 into develop Dec 6, 2019
@DalderupMaurice DalderupMaurice deleted the feature/add-wallet-label branch December 6, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant