Fixes reproducibility issues in MP plugin #387
Conversation
|
I wanted to hand test something, just to see if I'm being paranoid. Once, I do that, I think this will be fine. I'll have time today, |
|
Thanks |
There was a problem hiding this comment.
If you do nose2 --plugin nose2.plugins.mp -N this will throw an AttributeError. I would say the check should be < 0, so that the default works and adjust the error message. I tried to update this PR directly. I probably should write a test case for this scenario. Approved once the changes I made pass
nose2/plugins/mp.py
Outdated
| @procs.setter | ||
| def procs(self, value): | ||
| """Setter for procs property""" | ||
| if value <= 0: |
There was a problem hiding this comment.
If you do nose2 --plugin nose2.plugins.mp -N this will throw an AttributeError. I would say this should be < 0, so that the default works. And probably adjust the error message. I probably should write a test case for this scenario, we can just file a bug for that. Otherwise, I think the patch is fine.
|
@ptthiem Indeed, my bad for the error. :) |
|
commit merged in #389 |
3 participants
Closes #381