Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the UI container architecture to resolve a critical bug where config.json was being truncated in production environments.
The issue occurred because the previous Nitro-based server cached the
Content-Lengthof the static config.json file during the build process. When the entrypoint script attempted to overwrite this file at runtime with environment variables, the server continued to serve only the original number of bytes, resulting in truncated/invalid JSON and the "API is not compatible" error.Key Changes:
nuxt buildtonuxt generateto create a pure static export of the UI.entrypoint/directory. This server dynamically generates the config.json response, ensuring theContent-Lengthmatches the runtime environment variables./app/publicand handles SPA routing fallbacks toindex.html.pnpmsupport for the entrypoint dependencies.Related Issue
Closes not-three/main#27
Checklist
Additional Notes
entrypoint/with its own package.json and pnpm-lock.yaml for better isolation./app/publicis used to host the static assets, maintaining consistency with existing documentation.