docs: add helm chart readme#1099
Merged
akashsinghal merged 3 commits intonotaryproject:mainfrom Sep 28, 2023
Merged
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1099 +/- ##
=======================================
Coverage 52.28% 52.28%
=======================================
Files 101 101
Lines 6291 6291
=======================================
Hits 3289 3289
Misses 2684 2684
Partials 318 318 ☔ View full report in Codecov by Sentry. |
8165085 to
b3a1dd2
Compare
b3a1dd2 to
8eaf1b3
Compare
Collaborator
Author
|
@binbin-li @susanshi appreciate a review on this whenever you have a chance. No rush on this. |
binbin-li
reviewed
Sep 27, 2023
Contributor
binbin-li
left a comment
There was a problem hiding this comment.
Maybe it's quite a lot of work, wonder if we should pin to doc for each parameter or param group if we have doc on it.
binbin-li
approved these changes
Sep 28, 2023
Contributor
binbin-li
left a comment
There was a problem hiding this comment.
lgtm. For the doc link, as we discussed in the community meeting, we can reconsider how to add it in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a readme for helm chart values.
Inspiration from Gatekeeper's helm chart.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #564
Type of change
Please delete options that are not relevant.
mainbranch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change