fix: rename error for verifier plugins to be more generic#1129
Merged
akashsinghal merged 3 commits intonotaryproject:mainfrom Oct 19, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
=======================================
Coverage 52.30% 52.30%
=======================================
Files 101 101
Lines 6305 6305
=======================================
Hits 3298 3298
Misses 2688 2688
Partials 319 319
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What this PR does / why we need it:
Currently, external verifier plugin failures are wrapped in a single error code that's specific to signature failures. this is confusing for non signature artifacts such as vuln scans and SBOMs. This PR makes the error code more generic. The error code contains the plugin name which provides enough information to determine if it's a signature or not.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Corresponding doc change here: notaryproject/ratify-web#20
Type of change
Please delete options that are not relevant.
mainbranch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change