feat: support notation-go logs#1135
Merged
binbin-li merged 3 commits intonotaryproject:mainfrom Oct 20, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1135 +/- ##
=======================================
Coverage 52.30% 52.31%
=======================================
Files 101 101
Lines 6305 6306 +1
=======================================
+ Hits 3298 3299 +1
Misses 2688 2688
Partials 319 319
☔ View full report in Codecov by Sentry. |
akashsinghal
approved these changes
Oct 19, 2023
Collaborator
akashsinghal
left a comment
There was a problem hiding this comment.
LGTM. New logs are very helpful!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What this PR does / why we need it:
Currently Ratify does not have any logs from notation-go. This PR will integrate the Ratify logger with notation-go so that we can see logs from notation-go with
trace-idsupport.And notation-go will have the same log level as Ratify.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
mainbranch)How Has This Been Tested?
Debug logs from notation-go.

Checklist:
Post Merge Requirements
Helm Chart Change