Skip to content

ci: bump k8s versions#1182

Merged
akashsinghal merged 4 commits intonotaryproject:mainfrom
akashsinghal:akashsinghal/bumpk8sversions
Nov 22, 2023
Merged

ci: bump k8s versions#1182
akashsinghal merged 4 commits intonotaryproject:mainfrom
akashsinghal:akashsinghal/bumpk8sversions

Conversation

@akashsinghal
Copy link
Copy Markdown
Collaborator

Description

What this PR does / why we need it:

  • bumps k8s versions to 1.26 and 1.27
  • bumps k8s versions with supported AKS versions
  • bumps KIND cluster version for support 1.27 version
  • bumps CRD image build kube version to 1.27

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1181

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@akashsinghal akashsinghal self-assigned this Nov 20, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc2fcc1) 52.56% compared to head (246d02e) 52.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
- Coverage   52.56%   52.44%   -0.13%     
==========================================
  Files         101       83      -18     
  Lines        6344     5310    -1034     
==========================================
- Hits         3335     2785     -550     
+ Misses       2688     2273     -415     
+ Partials      321      252      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akashsinghal
Copy link
Copy Markdown
Collaborator Author

I've verified AKS e2e tests now pass on my fork: https://github.com/akashsinghal/ratify/actions/runs/6935154276

@akashsinghal akashsinghal marked this pull request as ready for review November 20, 2023 20:24
Copy link
Copy Markdown
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just one note out of scope, I feel we could add some variables shared by those github workflows to avoid updating one by one.

@akashsinghal akashsinghal enabled auto-merge (squash) November 22, 2023 18:49
@akashsinghal akashsinghal merged commit d57aa63 into notaryproject:main Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump supported K8s versions

2 participants