feat: add sbom verifier to helm chart#1204
Merged
susanshi merged 2 commits intonotaryproject:mainfrom Dec 10, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
=======================================
Coverage 55.09% 55.09%
=======================================
Files 104 104
Lines 6865 6865
=======================================
Hits 3782 3782
Misses 2751 2751
Partials 332 332 ☔ View full report in Codecov by Sentry. |
binbin-li
approved these changes
Dec 8, 2023
Contributor
binbin-li
left a comment
There was a problem hiding this comment.
one minor comment, lgtm overall
| | sbom.enabled | Enables/disables installation of sbom verification configuration | `false` | | ||
| | sbom.notaryProjectSignatureRequired | requires validation of sbom notation signature | `false` | | ||
| | sbom.disallowedLicenses | list of disallowed licenses | [] | | ||
| | sbom.disallowedPackages | list of disallowed packages defined by package name and version | [] | |
Contributor
There was a problem hiding this comment.
wonder if we should provide an example for package name/version pair?
Collaborator
There was a problem hiding this comment.
+1. You could consider pointing to the doc if the plan is to add that there. Not a blocker for this PR for me
Collaborator
Author
There was a problem hiding this comment.
thanks , I will merge this PR first to unblock release changes. and will add the example in a separate PR.
akashsinghal
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Doc walk through at notaryproject/ratify-web#44
Sample command:
helm install ratify
./charts/ratify --atomic
--namespace gatekeeper-system
--set featureFlags.RATIFY_CERT_ROTATION=true
--set sbom.enabled=true
--set sbom.disallowedLicenses={"Zlib"}
--set sbom.disallowedPackages[0].name="busybox"
--set sbom.disallowedPackages[0].version="1.36.1-r0"
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
mainbranch)How Has This Been Tested?
Validation #1 , modiefied local chart to populate disallowed license and package
validation #2, manual testing with installing command below:
helm install ratify
./charts/ratify --atomic
--namespace gatekeeper-system
--set featureFlags.RATIFY_CERT_ROTATION=true
--set sbom.enabled=true
--set sbom.disallowedLicenses={"Zlib"}
--set sbom.disallowedPackages[0].name="busybox"
--set sbom.disallowedPackages[0].version="1.36.1-r0"
Checklist:
Post Merge Requirements
Helm Chart Change