Conversation
Contributor
|
Great to see this and multiple repos adopting this oras-project/oras-go#133 |
etrexel
reviewed
Apr 27, 2022
Contributor
etrexel
left a comment
etrexel
left a comment
There was a problem hiding this comment.
LGTM with a few comments
etrexel
approved these changes
Apr 27, 2022
mnltejaswini
reviewed
May 2, 2022
|
|
||
| * Everyone is encouraged to participate in code reviews. | ||
| * It is best to get approval from contributors with knowledge about the code paths being modified. You can identify an appropriate reviewer by looking through the file history to find frequent contributor. Contributors can not be directly added as reviews but can be notified via a comment. | ||
| * When you provide feedback, make it clear if the change must be made for the pull request to be approved, or if it is just a suggestion. Mark suggestions with `nit`. |
Contributor
There was a problem hiding this comment.
mnltejaswini
approved these changes
May 2, 2022
bspaans
pushed a commit
to bspaans/ratify
that referenced
this pull request
Oct 17, 2023
* add publish helm chart action on release * Adding initial version of reviewing guideline * Adding reviewing guide * incoporate appropriate guidelines from oras project * fixing typo in Stability section * apply suggested change workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding review policy for Ratify