Skip to content

Fix Configuration File Inconsistencies#235

Merged
susanshi merged 3 commits intonotaryproject:mainfrom
akashsinghal:akashsinghal/updateConfigCase
Jul 12, 2022
Merged

Fix Configuration File Inconsistencies#235
susanshi merged 3 commits intonotaryproject:mainfrom
akashsinghal:akashsinghal/updateConfigCase

Conversation

@akashsinghal
Copy link
Collaborator

Description

Please include a summary of the changes and relevant context. Please also reference any related issue in your repository.

  • Switch config to using camel case everywhere
  • Switch highest level schema of JSON to be singular stores --> store, policies --> policy, verifiers --> verifier

Fixes #233

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • ran all tests use make test
  • deployed to k8s cluster and verified server logs from ratify are correct

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

@akashsinghal akashsinghal requested a review from susanshi July 6, 2022 18:46
@akashsinghal akashsinghal changed the title Akashsinghal/update config case Fix Configuration File Inconsistencies Jul 6, 2022
@susanshi susanshi merged commit f47c754 into notaryproject:main Jul 12, 2022
@akashsinghal akashsinghal deleted the akashsinghal/updateConfigCase branch December 5, 2022 21:27
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
* switch to use camelCase everywhere

* switch to singular in top level config json

* fix small error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Ratify configuration naming inconsistency

2 participants