Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
binbin-li
reviewed
Oct 13, 2022
susanshi
reviewed
Oct 13, 2022
…hsinghal/ratify into akashsinghal/addConcurrency
binbin-li
reviewed
Oct 19, 2022
binbin-li
reviewed
Oct 19, 2022
…hsinghal/ratify into akashsinghal/addConcurrency
sajayantony
approved these changes
Oct 21, 2022
fseldow
pushed a commit
to fseldow/ratify
that referenced
this pull request
Dec 7, 2022
* adding oras store locking and concurrency for multiple subjects * small fix; add concurrency to store and artifact * add testing and more fixes * remove timing logic * first round of comments * address more comments * attempt to resolve codeql * codeql fix * add utils package * make insecure client config go routine safe * update to use custom http client settings * use http constants instead * bump default cpu and memory for pod
bspaans
pushed a commit
to bspaans/ratify
that referenced
this pull request
Oct 17, 2023
* adding oras store locking and concurrency for multiple subjects * small fix; add concurrency to store and artifact * add testing and more fixes * remove timing logic * first round of comments * address more comments * attempt to resolve codeql * codeql fix * add utils package * make insecure client config go routine safe * update to use custom http client settings * use http constants instead * bump default cpu and memory for pod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds necessary locks and synchronization code to the ORAS store and executor to go routines for all execution operations
Implementation Plan: https://hackmd.io/@akashsinghal/SyCJn6NGs
Fixes #153
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist: