Add wrapper for http response with version#346
Merged
sajayantony merged 3 commits intonotaryproject:mainfrom Oct 21, 2022
Merged
Add wrapper for http response with version#346sajayantony merged 3 commits intonotaryproject:mainfrom
sajayantony merged 3 commits intonotaryproject:mainfrom
Conversation
akashsinghal
previously approved these changes
Oct 12, 2022
Collaborator
|
Hi @etrexel , i see this change requires a doc update, could you point us to the doc? |
akashsinghal
previously approved these changes
Oct 21, 2022
e40373f to
1a1b36c
Compare
akashsinghal
approved these changes
Oct 21, 2022
fseldow
pushed a commit
to fseldow/ratify
that referenced
this pull request
Dec 7, 2022
bspaans
pushed a commit
to bspaans/ratify
that referenced
this pull request
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new type that represents the response for an http request. This type insulates the internal implementation from external consumers and adds a version field so that we can track changes that could break external consumers. For now the format of the response is still not that formally typed, but this gives a starting point.
Fixes #261
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist: