Update chart to support azure msi oras auth provider#424
Update chart to support azure msi oras auth provider#424sajayantony merged 1 commit intonotaryproject:mainfrom
Conversation
| readOnly: true | ||
| {{- if .Values.akvCertConfig.enabled }} | ||
| {{- range $index, $secretProviders := .Values.akvCertConfig.secretProviders }} | ||
| - mountPath: "/usr/local/ratify-certs/notary-{{ $index }}" |
There was a problem hiding this comment.
I have a concern on the new notary trust store. A notary verifier can only load certs from one specified directory. If we have multiple cert directory, how do you plan to integrate with notation?
There was a problem hiding this comment.
It is a good question. The change is based on current ratify verifier configuration that will declare the cert path. And for AKV csi secret, certs from multiple keyvaults have to be mount on container with different volumeMount. Volume mountPath is unique for container configuration.
So my idea is that when we transfer to trust store:
Option 1. we do not use akv csi secret to download the cert, ratify creates its own azure provider to download it.
Option 2. according to the cert path declared in verifier crd, ratify pod will initially copy the certs to specified directory.
WDYT?
There was a problem hiding this comment.
synced offline, notation verifier will support in-memory certs soon, then we could support mount arbitrary number of directories to certs. We could just keep Chart update to support Azure MSI as oras auth provider. in this PR to unblock it. And have Chart update to support AKV cert from multiple keyvault and certs in a following PR once notation side is done.
bc919b1 to
e7188ce
Compare
3a24389 to
a9febb4
Compare
a9febb4 to
032ce26
Compare
Description
Chart update to support Azure MSI as oras auth provider.
Chart update to support AKV cert from multiple keyvault and certs
Fixes # 314
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist: