Skip to content

test: add e2e tests for CLI and Add-on#458

Merged
susanshi merged 3 commits intonotaryproject:mainfrom
binbin-li:cli-test
Dec 7, 2022
Merged

test: add e2e tests for CLI and Add-on#458
susanshi merged 3 commits intonotaryproject:mainfrom
binbin-li:cli-test

Conversation

@binbin-li
Copy link
Copy Markdown
Contributor

@binbin-li binbin-li commented Dec 2, 2022

Description

Add basic e2e tests for verification through Command.

  1. Notary verifier: added
  2. Cosign verifier: added
  3. Licensechecker veirifer: added
  4. Sbom verifier: Added a basic test. But it would fail if we specify a policy with both sbom and notary types which is tracked by Fix Config Policy Provider for Nested References #351.

Add sbom verifier test for add-on e2e test suite.

It also includes changes from this PR: #469, will get rebased once it's merged.

Part of tests for #283

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Run tests in CI

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

@binbin-li binbin-li force-pushed the cli-test branch 6 times, most recently from 2eb8a9a to bd714b4 Compare December 5, 2022 04:18
@binbin-li binbin-li changed the title [WIP][DO NOT REVIEW] CLI test test: add e2e tests for CLI Dec 5, 2022
@binbin-li binbin-li force-pushed the cli-test branch 10 times, most recently from 566a1f7 to 891b524 Compare December 6, 2022 06:43
@binbin-li binbin-li changed the title test: add e2e tests for CLI test: add e2e tests for CLI and Add-on Dec 6, 2022
Copy link
Copy Markdown
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to see addition of so many automated test, left some comments, thanks!

@binbin-li binbin-li force-pushed the cli-test branch 5 times, most recently from 26eecc1 to 5feff80 Compare December 7, 2022 05:20
Signed-off-by: Susan Shi <huish@microsoft.com>
Copy link
Copy Markdown
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. merging before we cut the release

@susanshi susanshi merged commit 966d007 into notaryproject:main Dec 7, 2022
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Signed-off-by: Susan Shi <huish@microsoft.com>
Co-authored-by: Susan Shi <huish@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants