Skip to content

Update quick start to latest image#477

Merged
binbin-li merged 9 commits intonotaryproject:mainfrom
evantravers18:updateGetStarted
Dec 20, 2022
Merged

Update quick start to latest image#477
binbin-li merged 9 commits intonotaryproject:mainfrom
evantravers18:updateGetStarted

Conversation

@susanshi
Copy link
Collaborator

@susanshi susanshi commented Dec 8, 2022

Description

Update quick start to latest image signed with Notation RC1

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Copy link
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing it!

@binbin-li
Copy link
Contributor

Just wonder why the e2e test was not triggered.

@binbin-li binbin-li closed this Dec 14, 2022
@binbin-li binbin-li reopened this Dec 14, 2022
@binbin-li binbin-li closed this Dec 14, 2022
@binbin-li binbin-li reopened this Dec 14, 2022
@akashsinghal
Copy link
Collaborator

Found the issue for why PR is blocked. The build-pr workflow doesn't trigger for changes only to markdown files

@akashsinghal akashsinghal mentioned this pull request Dec 19, 2022
4 tasks
@binbin-li binbin-li merged commit 6510835 into notaryproject:main Dec 20, 2022
@susanshi susanshi deleted the updateGetStarted branch March 8, 2023 18:53
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Sajay Antony <sajaya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants