Skip to content

chore: enable more linters and fix errors (part 2)#552

Merged
akashsinghal merged 1 commit intonotaryproject:mainfrom
aramase:lint-errors-part-2
Jan 17, 2023
Merged

chore: enable more linters and fix errors (part 2)#552
akashsinghal merged 1 commit intonotaryproject:mainfrom
aramase:lint-errors-part-2

Conversation

@aramase
Copy link
Contributor

@aramase aramase commented Jan 17, 2023

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Description

What this PR does / why we need it:

  • enable more linters and fix errors (part 2)

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

part of #546

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

@aramase aramase mentioned this pull request Jan 17, 2023
20 tasks
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the lint-errors-part-2 branch from 2a86f36 to 69733bd Compare January 17, 2023 21:00
@aramase aramase marked this pull request as ready for review January 17, 2023 21:02
Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akashsinghal akashsinghal merged commit 577dd08 into notaryproject:main Jan 17, 2023
@aramase aramase deleted the lint-errors-part-2 branch January 17, 2023 22:34
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants