feat: support OCI Image#683
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
+ Coverage 44.57% 44.59% +0.01%
==========================================
Files 56 56
Lines 3244 3301 +57
==========================================
+ Hits 1446 1472 +26
- Misses 1651 1682 +31
Partials 147 147
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
susanshi
left a comment
There was a problem hiding this comment.
LGTM. Left some questions that can be addressed later if needed.
| oras attach \ | ||
| --artifact-type org.example.sbom.v0 \ | ||
| --plain-http \ | ||
| --image-spec v1.1-image \ |
There was a problem hiding this comment.
we can move the image spec version to a variable it can be easily updated.
|
we should also add doc to state we support both format incase customer have questions |
binbin-li
left a comment
There was a problem hiding this comment.
Left one minor comment, lgtm.
Yes agreed. I'm struggling to figure out where to put though since we don't have an ORAS store specific doc. |
97d574e to
0bb6552
Compare
We can add a new section under conCecpt -> store , and add a link from store CRDs. https://github.com/deislabs/ratify/blob/main/docs/developer/store.md This will be similar to section for Notary at https://github.com/deislabs/ratify/blob/main/docs/developer/verifier.md#section-6-built-in-verifiers |
Description
What this PR does / why we need it:
Most verifiers rely on the Blobs field to enumerate the content of each artifact. This field is populated directly from the manifest byte marshalling. In the case of an OCI Image referrer, this marshalling will not populate Blobs causing all other verifiers to prematurely finish before any content is verified. This PR:
Blobsand adds logic in ORAS store to marshal Layers/Blobs to theBlobsfield depending on the referrer media type.BlobsfieldTODO: Add e2e test with OCI Image and OCI Artifact as referrer manifest type
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist: