Skip to content

spec: update signature spec for OCI artifact manifest#203

Merged
yizha1 merged 3 commits intonotaryproject:mainfrom
yizha1:sig_spec
Nov 22, 2022
Merged

spec: update signature spec for OCI artifact manifest#203
yizha1 merged 3 commits intonotaryproject:mainfrom
yizha1:sig_spec

Conversation

@yizha1
Copy link
Copy Markdown
Contributor

@yizha1 yizha1 commented Nov 11, 2022

Update signature spec for Notary v2 using OCI artifact manifest to store the signature in the repository, as well as OCI image manifest to store the signature in the repository that doesn't support OCI artifact manifest.

Signed-off-by: Yi Zha yizha1@microsoft.com

Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 added the spec label Nov 11, 2022
@yizha1 yizha1 added this to the RC-1 milestone Nov 11, 2022
@yizha1 yizha1 linked an issue Nov 11, 2022 that may be closed by this pull request
@yizha1 yizha1 removed this from the RC-1 milestone Nov 14, 2022
priteshbandi
priteshbandi previously approved these changes Nov 14, 2022
Comment thread specs/signature-specification.md Outdated
Comment thread specs/signature-specification.md
@priteshbandi priteshbandi self-requested a review November 14, 2022 11:14
Comment thread specs/signature-specification.md Outdated
Comment thread specs/signature-specification.md Outdated
Comment thread specs/signature-specification.md Outdated
Comment thread specs/signature-specification.md Outdated
Comment thread specs/signature-specification.md Outdated
@priteshbandi priteshbandi dismissed their stale review November 14, 2022 11:38

Added some questions

Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 requested a review from priteshbandi November 15, 2022 04:04
Copy link
Copy Markdown
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread specs/signature-specification.md Outdated
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 requested review from priteshbandi and removed request for dtzar November 18, 2022 06:35
Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@michaelb990 michaelb990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yizha1 yizha1 added this to the RC-1 milestone Nov 21, 2022
@yizha1 yizha1 self-assigned this Nov 21, 2022
@yizha1 yizha1 merged commit 21783e5 into notaryproject:main Nov 22, 2022
@yizha1 yizha1 deleted the sig_spec branch November 22, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

spec: update signature spec for OCI artifact

5 participants