Skip to content

Fix opening multi-files on Notepad++ multi-instance mode regression#37

Closed
donho wants to merge 2 commits intonotepad-plus-plus:masterfrom
donho:fix_multi_files_open_issue
Closed

Fix opening multi-files on Notepad++ multi-instance mode regression#37
donho wants to merge 2 commits intonotepad-plus-plus:masterfrom
donho:fix_multi_files_open_issue

Conversation

@donho
Copy link
Copy Markdown
Member

@donho donho commented Jun 15, 2023

Before this commit, if N files are selected, NppShell calls Notepad++ N times (each time for per file).
In this commit, we call Notepad++ only once, instead of calling it N times.

Fix #36, fix notepad-plus-plus/notepad-plus-plus#13778

@donho
Copy link
Copy Markdown
Member Author

donho commented Jun 15, 2023

@GurliGebis
Since I've got vacant time, I do the fix for this issue.
Could you review this PR please?

@donho
Copy link
Copy Markdown
Member Author

donho commented Jun 15, 2023

Hmm... it doesn't really fix it.
I'll do another commit to get it right.

@donho
Copy link
Copy Markdown
Member Author

donho commented Jun 15, 2023

@GurliGebis
Ready for being reviewed, It should be OK now.

@GurliGebis
Copy link
Copy Markdown
Contributor

@donho looks exactly like the correct solution 🙂

@donho donho closed this in 6cf9b2f Jun 17, 2023
@donho donho deleted the fix_multi_files_open_issue branch June 17, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants