Skip to content

Conversation

@xomx
Copy link

@xomx xomx commented Jun 15, 2025

Fix notepad-plus-plus/notepad-plus-plus#16626

The Never button of the updater dialog needs to be disabled if there is no Notepad++ messages receiving capable window behind to fulfill the NPPM_DISABLEAUTOUPDATE command.

Other small fixes:

  • some nullptr inits
  • logging possible ShellExecute failure
  • instead of always returning 0 (aka success) at the winmain exit, return also the possible ShellExecute WIN32 failure code

xomx added 2 commits June 5, 2025 18:41
Disabling the "Never" Notepad++ Update Available dialog button, when there is not a Notepad++ app running to receive the inter-process NPPM_DISABLEAUTOUPDATE msg.

(+ some minor fixes)
@donho
Copy link
Member

donho commented Jun 16, 2025

@xomx

The Never button of the updater dialog needs to be disabled if there is no Notepad++ messages receiving capable window behind to fulfill the NPPM_DISABLEAUTOUPDATE command.

OK. But this enhancement has nothing to do with our conversation here: notepad-plus-plus/notepad-plus-plus#16626 (comment)

@xomx
Copy link
Author

xomx commented Jun 16, 2025

@donho

But this enhancement has nothing to do with our conversation here: notepad-plus-plus/notepad-plus-plus#16626 (comment)

Yes (it is related to another comment there: notepad-plus-plus/notepad-plus-plus#16626 (comment) )


Maybe(?) you confused it with my NSIS-related commit notepad-plus-plus/notepad-plus-plus@719ca33 there preceding my words

Sorry, I don't really follow you - could you elaborate ?

Just submitted a patch that illustrates what I meant.

in notepad-plus-plus/notepad-plus-plus#16626 (comment)

@donho donho self-assigned this Jun 17, 2025
@donho donho closed this in 3c3c245 Jun 17, 2025
@xomx xomx deleted the misleading_YesNoNeverDlg_NeverBtn_when_no_NppWnd_behind branch June 20, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants