Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the resize handle was calling
setSidebarWidthon every mouse move frame which triggered a full react re-render cascade through the entire sidebar context — including all consumers likeAppSidebarandHomeContent— 60 times per second during a drag. it was also writing todocument.cookieon every frame which is just unnecessary i/o on the hot path.what changed:
sidebar.tsx— swappeduseStateforuseRefon the resizing flag so toggling it doesn't cause a re-render. movedmousemove/mouseuplisteners into a single stableuseEffectthat runs once on mount instead of re-registering on every state change. during drag, width is now applied by directly mutating the css variable on the wrapper element and setting inline styles on the sidebar panel and spacer div — no react involved.setSidebarWidth(and the cookie write) is called exactly once onmouseupwith the final value. added adata-resizingattribute on drag start that's picked up by an injected style rule to kill all transitions inside the wrapper while dragging, which prevents the right side from animating toward the new width instead of following it instantly. addedspacerRefto the spacer div so it can be updated directly in sync with the sidebar during drag.HomeClientLayout.tsx— removedtransition-all duration-300 ease-in-outfrom the<main>element. this was the biggest visible offender — the content area was smoothly animating its position on every pixel of mouse movement.result: re-renders per drag went from ~60/sec to exactly 1 on release. cookie writes same. the right side now follows the drag handle frame-perfectly.