Conversation
Co-authored-by: notfolder <20558197+notfolder@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Playwright support with Docker environment
Add Playwright integration specification for browser testing in execution environments
Dec 7, 2025
notfolder
reviewed
Dec 7, 2025
| └── playwright/ # Playwright MCP Server作業ディレクトリ | ||
| ``` | ||
|
|
||
| #### 3.1.3 環境変数設定 |
| ENTRYPOINT ["/bin/bash", "-c", "/workspace/start-mcp-servers.sh && sleep infinity"] | ||
| ``` | ||
|
|
||
| ### 3.2 イメージサイズ対策 |
| └── Dockerfile # 通常版(Playwrightなし) | ||
| ``` | ||
|
|
||
| **注記:** |
Contributor
Author
There was a problem hiding this comment.
Java-PlaywrightとGo-Playwrightバリアントを追加しました。全ての言語環境でPlaywright版を提供します。(482e63c)
| 3. スクリーンショット撮影や要素検証を実行 | ||
| ``` | ||
|
|
||
| #### 4.1.3 Docker間通信(将来拡張) |
|
|
||
| --- | ||
|
|
||
| ## 12. 実装優先順位 |
Contributor
Author
There was a problem hiding this comment.
実装優先順位セクション(旧12章)を削除し、以降のセクション番号を繰り上げました。(482e63c)
| - ホワイトリストモードの使用を推奨 | ||
| - プロダクション環境へのアクセスは慎重に | ||
|
|
||
| #### 14.1.3 Docker間通信(将来対応) |
Contributor
Author
There was a problem hiding this comment.
ポート番号管理セクション(14.2)とDocker間通信セクション(14.1.3)を削除しました。(482e63c)
| ENV DISPLAY=:99 | ||
| ``` | ||
|
|
||
| #### 3.1.4 起動スクリプト |
| echo $! > /workspace/mcp-servers/text-editor/server.pid | ||
| ``` | ||
|
|
||
| **ENTRYPOINT変更:** |
…ywright variants, dynamic MCP addition Co-authored-by: notfolder <20558197+notfolder@users.noreply.github.com>
Contributor
Author
notfolder
reviewed
Dec 7, 2025
|
|
||
| 実行環境Docker内でバックグラウンドプロセスとして起動し、stdio経由でLLMと通信します。 | ||
|
|
||
| **起動方法:** |
Owner
There was a problem hiding this comment.
entry pointで起動するのではなく、text-editor mcpサーバーと同じ立ち上げ方にして下さい
起動方法の詳細を記述してください
Contributor
Author
There was a problem hiding this comment.
text-editor MCPと同じ起動方式に変更しました。
変更内容:
- セクション2.2.2:
docker exec -iを使用したstdio通信方式を明記 - セクション5.2.3: MCPサーバー起動の詳細シーケンス図と実装方法を追加
- セクション5.4.1: PlaywrightMCPClientクラスの詳細実装(subprocess.Popen、start/stop、JSON-RPC通信)
- セクション5.4.2: ExecutionEnvironmentManagerでの
_start_playwright_mcp()メソッド実装とprepare()での起動フローを追加
text-editor MCPと同じく、ENTRYPOINTでの起動ではなく、ExecutionEnvironmentManagerがdocker execでMCPサーバープロセスを起動し、stdioで通信する方式としました。(345a57f)
Co-authored-by: notfolder <20558197+notfolder@users.noreply.github.com>
Contributor
Author
Owner
|
@copilot |
…cker exec command Co-authored-by: notfolder <20558197+notfolder@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.