Merged
Conversation
… a deprecated method on WebDriverException which i don't like one bit. Better ideas appreciated :)
…right thing before!
In Selenium 2.53.0, the error code mapper would not match the UnsupportedCommandException and so would return the default value of UNHANDLED_ERROR. In 3.0, we correctly map this to the more appropriate error code of UNKNOWN_COMMAND, which describes the lack of a match more appropriately.
I'm not sure why this was added, and the commit it landed in doesn't explain why the change was made. Reverting, since it appears to be unnecessary.
The previous version was almost impossible for a human being to understand. Following the maxim that you need to be twice as smart to debug something as to write it, going for a nice and clear version instead.
How this exception is serialised isn't documented, but some local end bindings (such as python and .Net) expect it to be serialised as a JSON Object. By adding this accessor, the BeanToJsonConverter will add the right property.
on alert handling we are encountering this bug: https://bugs.chromium.org/p/chromedriver/issues/detail?id=1500 seems to occur at random. We either need to ignore the chrome alert tests or wrap every alert call handling the error. until the chromedriver bug is fixed
getting in front of the travis zealots who love this thing for some reason
…load to be forwarded to the node There's some black magic in grid, where a registered nodes capabilities would get munged with a new session request that was forwarded to the node. Don't care about removing stuff related to grid v1, that's no longer supported. This has no affect on grid customizers, beforeSession / beforeCommand still process as they did... but now all of the request is available without it being munged. This enables users to pass the 'Required Capabilities' in the new session request and it will actually come through.
…menting out. The tests pass with the version installed in travis anyways.
Also add a link to an article explaining microtasks.
…siredCapabilities Crazy that the java server needs to fully deserialize a request to process it. Fixing that will be a massive change, so this will have to do. Fixes #3115
…r exception due to multiple error status matches Fixes #3117
…luding: Added support for test results server for scheduled tests Added external plugin support for scheduler Added support for remote playback for tests using webdriver Added option for selecting how an existing window is used for webdriver playback Added close webdriver session toolbar button Added toolbar button for selecting a common browser for webdriver playback Improved webdriver playback Fixed failing gist creation Fixed counter in health service Added more health event logging Changed to secure urls where possible
Signed-off-by: Titus Fortner <titusfortner@gmail.com>
Signed-off-by: Titus Fortner <titusfortner@gmail.com>
…uild The build process had been omitting the JavaScript files that represent the atoms for isDisplayed and getAttribute for strongly-named assemblies. This commit corrects that oversight. Fixes issue #3137.
…m file Because of the large number of JavaScript files we pass through the Closure compiler for some targets, we are running over the 8192 character limit of the command line in Windows. The workaround is to have the Closure compiler read its command-line flags from a file instead.
Signed-off-by: Titus Fortner <titusfortner@gmail.com>
…lly this will stabilise Chrome
Signed-off-by: Titus Fortner <titusfortner@gmail.com>
Signed-off-by: Titus Fortner <titusfortner@gmail.com>
Signed-off-by: Titus Fortner <titusfortner@gmail.com>
Signed-off-by: Titus Fortner <titusfortner@gmail.com>
This also changes it so that the deprecation warning for reading driver_path is only shown if the user explicitly asks for it. Since it is called in the Service init, it would have always shown if there was no driver_path passed in. Also removed some duplication when finding the binary Signed-off-by: Titus Fortner <titusfortner@gmail.com>
…ap (#3151) HashBiMap is not thread safe. And its ability to map back from value to key is used in a single place and can be easily replaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement