Make number nullable #167
Merged
Make number nullable #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoditkarVedant
requested changes
Oct 5, 2021
Contributor
KoditkarVedant
left a comment
KoditkarVedant
left a comment
There was a problem hiding this comment.
@kashifsoofi First of all thank you for your contribution. You also need to make date, email, and rollup types nullable. You can find them in their respective PropertyValue type classes.
Contributor
Author
|
Sure I think i checked those, let me update, thanks |
Contributor
Author
|
Email is string so that is nullable and so are the objects |
KoditkarVedant
requested changes
Oct 5, 2021
Contributor
KoditkarVedant
left a comment
KoditkarVedant
left a comment
There was a problem hiding this comment.
@kashifsoofi I've left a small comment. Rest LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make number property nullable.
Fixes #164
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: