Skip to content

Make number nullable #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Make number nullable #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69c7f74
Make number nullable
kashifsoofi Oct 4, 2021
2eff99e
Make number and date nullable
kashifsoofi Oct 5, 2021
050bdce
Remove nullable from class
kashifsoofi Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Src/Notion.Client/Models/PropertyValue/NumberPropertyValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ public class NumberPropertyValue : PropertyValue
/// Value of number
/// </summary>
[JsonProperty("number")]
public double Number { get; set; }
public double? Number { get; set; }
}
}
2 changes: 1 addition & 1 deletion Src/Notion.Client/Models/PropertyValue/RollupPropertyValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class RollupValue
/// Number rollup property values contain a number
/// </summary>
[JsonProperty("number")]
public double Number { get; set; }
public double? Number { get; set; }

/// <summary>
/// Date rollup property values contain a date property value.
Expand Down