Skip to content

Conversation

@Poltuu
Copy link
Contributor

@Poltuu Poltuu commented May 17, 2023

Description

This PR introduces the optional CancellationToken cancellationToken parameters into every api calls. This let the user cancel the tasks, which is pretty useful and standard practice around tasks

No issue with this PR

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

No test were performed with this, but there is not much to test thus 🤷

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@KoditkarVedant KoditkarVedant merged commit fcccb07 into notion-dotnet:main Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants