slient -> silent, nofitication -> notification typos#174
slient -> silent, nofitication -> notification typos#174jannotti wants to merge 4 commits intonotnoop:masterfrom
Conversation
|
+1 on a single |
|
I just added a category() method, analogous to the badge() and sound() method to set aps.category. It's needed to use the new notifcation actions in iOS8. |
|
According the video "What's new in iOS Notifications" from WWDC 2014 (Watch from 15:12), and in my tests, Apple has increased the payload limit to 2k. |
|
@jannotti +1 on category; I added the 2k already to the java-apns: java-apns#5 ; I tested that already w/ an existing iOS7 app. Works fine |
|
@jannotti +1 on this PR, it includes the 2k already - just seeing that :-) and nice fixing typos |
|
|
|
Hello @jannotti I merged most of this into java-apns@1f69968 the 2k payload I used my own PR (as that includes JAvaDoc updates as well): Thanks for the PR! We will 🚢 that in a beta3 release soon-ish ;-) |
|
Ok, this is commit java-apns/java-apns@1f69968. |
This just corrects a few typos in a method name.
More important to discuss - I think this method is setting content-available in the wrong place. My reading of the docs says this method should do it in aps, just like forNewstand() does.
If I'm right, I'd propose that both methods go away in favor of a single method called "contentAvailable".