fix: replace all Anti-Pattern terminology with Failure Mode#636
Merged
Conversation
Extends joy-check enforcement beyond headings to all prose contexts: table column headers, bold labels, inline references, blockquote scopes. 302 occurrences replaced across 179 files. 27 instances inside fenced code blocks preserved (legitimate Go/Python examples showing patterns to detect). Validator expanded: Anti-Pattern regex now matches all prose positions, not just markdown headings. Catches future regressions in table cells, inline text, and reference descriptions. Exclusions preserved: fenced code blocks, allowlisted files (PHILOSOPHY.md, instruction-rubric.md, voice corpus).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^\s*#{1,6}.*Anti-Pattern) to all prose positions (Anti-Patterns?)s/Anti-Pattern/Failure Mode/— zero semantic editsTest plan
python3 scripts/validate_positive_instruction_docs.pyreturnscount: 0pytest scripts/tests/test_joy_check_instruction_mode.py— all pass// Anti-pattern:(preserved)