feat: Add ApplyConfig in NotNet engine#1
Merged
Not-Dhananjay-Mishra merged 3 commits intomainfrom Apr 6, 2026
Merged
Conversation
Not-Dhananjay-Mishra
changed the title
ApplyConfig in NotNet engine
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an ApplyConfig chaining API intended to let callers apply EngineOption configuration after route/group registration, plus adds expanded GoDoc comments, tests, and a usage example.
Changes:
- Add
Engine.ApplyConfig(*EngineOption)andGroup.ApplyConfig(*EngineOption)chaining methods. - Expand documentation comments across request/response helpers and engine APIs.
- Add tests and an example file demonstrating
ApplyConfigusage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| pkg/notnet/reqandresp.go | Adds/expands GoDoc comments for request/response helpers and pooling functions. |
| pkg/notnet/notnet.go | Adds ApplyConfig to Engine and Group; expands GoDoc comments for engine APIs. |
| pkg/notnet/notnet_test.go | Adds tests covering ApplyConfig behavior (currently not asserting actual config effects, and includes a timing-based test). |
| example/applyconfig.go | Adds an example snippet demonstrating chained ApplyConfig usage (currently not invoked by the runnable example). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…r ApplyConfig Agent-Logs-Url: https://github.com/nottechdm/notnet/sessions/9c9a2ffd-6399-4c01-a802-1eac6709a640 Co-authored-by: Not-Dhananjay-Mishra <218332346+Not-Dhananjay-Mishra@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
ApplyConfigin NotNet enginewith this we can now apply custom config for any particular route
Example :