feat(api, dashboard): Topics management #8193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| organizationId: user.organizationId, | ||
| userId: user._id, | ||
| topicKey, | ||
| force: true, |
Contributor
There was a problem hiding this comment.
Let's fix this one, we are telling the users in the exception that they can pass force=true while it is not possible.
Suggested change
| force: true, | |
| force: query.force || false, |
Contributor
Author
There was a problem hiding this comment.
We actually don't tell this to users, I have kept it as only internal thing. Where di you see it?
Contributor
There was a problem hiding this comment.
I noticed this in the DeleteTopicUseCase. Just sharing a few thoughts, no need to answer directly:
If we don’t plan to expose this route externally, do we really need this logic?
If or when we do expose it, we should make sure to revisit and update this part accordingly.
djabarovgeorge
approved these changes
May 5, 2025
djabarovgeorge
approved these changes
May 5, 2025
bricehemery
pushed a commit
to jack-agency/novu
that referenced
this pull request
Jul 7, 2025
Co-authored-by: George Djabarov <39195835+djabarovgeorge@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer