fix(dashboard): Hide issues on step first render #8209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LetItRock
approved these changes
Apr 25, 2025
This is the second attempt to hide the step issues the first time we open the step editor right after its creation. The previous implementation use History Push State suffered from the issue of not rendering any issue even after the first autosave. The second attempt resolves that. So issues should be hidden from the form right after its creation until the first autosave.
SokratisVidros
force-pushed
the
hide_errors_on_step_first_render
branch
from
b79ad5b to
9a3f0d9
Compare
bricehemery
pushed a commit
to jack-agency/novu
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
This is the second attempt to hide the step issues the first time we open the step editor right after its creation.
The previous implementation use History Push State suffered from the issue of not rendering any issue even after the first autosave.
The second attempt resolves that. So issues should be hidden from the form right after its creation until the first autosave.