-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(dashboard): updated the subscriberid to support multi tenancy (MRK-700) #8278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
scopsy
reviewed
May 12, 2025
Co-authored-by: Dima Grossman <dima@grossman.io>
scopsy
approved these changes
May 12, 2025
Contributor
|
@iampearceman looks good! I've added another suggestion that should fix the failing CI |
Contributor
|
@iampearceman ping |
Co-authored-by: Dima Grossman <dima@grossman.io>
bricehemery
pushed a commit
to jack-agency/novu
that referenced
this pull request
Jul 7, 2025
…RK-700) (novuhq#8278) Co-authored-by: Dima Grossman <dima@grossman.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
I've updated the Inbox's subscriber_id to support multi-tenancy (include org_id in the subscriber_id)