feat(js): override icon set for inbox component #8293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
scopsy
changed the title
@novu/js
@novu/nextjs
novu
@novu/react
@novu/react-native
commit: |
scopsy
commented
May 14, 2025
scopsy
commented
May 14, 2025
Comment on lines
6
to
33
| type IconRendererWrapperProps = { | ||
| iconKey: IconKey; | ||
| fallback: JSX.Element; | ||
| class?: string; | ||
| }; | ||
|
|
||
| export const IconRendererWrapper = (props: IconRendererWrapperProps) => { | ||
| let el: HTMLDivElement | undefined; | ||
| let cleanup: (() => void) | undefined; | ||
| const appearance = useAppearance(); | ||
| const customRenderer = () => appearance.icons()?.[props.iconKey]; | ||
|
|
||
| onMount(() => { | ||
| if (el && customRenderer()) { | ||
| cleanup = (customRenderer() as IconRenderer)(el, { class: props.class }); | ||
| } | ||
| }); | ||
|
|
||
| onCleanup(() => { | ||
| cleanup?.(); | ||
| }); | ||
|
|
||
| return ( | ||
| <Show when={customRenderer()} fallback={props.fallback}> | ||
| {/* Render the placeholder div. The user's renderer will populate it. */} | ||
| <span ref={el} /> | ||
| </Show> | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
@LetItRock this is the rendering wrapper utility function for icons
Comment on lines
+20
to
+24
| { | ||
| iconKey, | ||
| }: { | ||
| iconKey?: IconKey; | ||
| } = {} |
Contributor
Author
There was a problem hiding this comment.
Added options object, with an optional iconKey param
Contributor
Author
There was a problem hiding this comment.
Was duplicated with clock
| }; | ||
| } | ||
|
|
||
| export function adaptAppearanceForJs(appearance?: ReactAppearance): JsAppearance | undefined { |
Contributor
Author
There was a problem hiding this comment.
This function remaps the jsx syntx to novu/js
scopsy
commented
May 14, 2025
|
|
||
| if (hasAppearanceKey) { | ||
| return; // Skip reporting if appearanceKey is present, as it is most likely forwarded. | ||
| if (!node.name || node.name.name !== 'class') { |
Contributor
Author
There was a problem hiding this comment.
Fixed the linter to allow using variables with style
LetItRock
approved these changes
May 14, 2025
packages/js/src/ui/components/Notification/DefaultNotification.tsx
Outdated
Show resolved
Hide resolved
packages/js/src/ui/components/Notification/NotificationActions.tsx
Outdated
Show resolved
Hide resolved
bricehemery
pushed a commit
to jack-agency/novu
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Introduce a new icons key in the
appereanceprop:Icon keys are discovarable via the 🖼️ emoji on the class.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer