Skip to content

Conversation

@merrcury
Copy link
Member

What changed? Why was the change needed?

This fixes NV-6034

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@linear
Copy link

linear bot commented Jun 10, 2025

@netlify
Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for dashboard-v2-novu-staging canceled.

Name Link
🔨 Latest commit 19d0c4b
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/684815f6299a970008a1533a

@merrcury
Copy link
Member Author

merrcury commented Jun 10, 2025

@scopsy Hey, I did some research — we’ll still need to publish the tag and release manually. I’ll put together some documentation for it. The issue with publishing the release and tag through the action is that it would tag the older version, without including this change that’s currently not merged in next.

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we going to test it out? Maybe doing a nightly release or something like this?

@merrcury
Copy link
Member Author

How are we going to test it out? Maybe doing a nightly release or something like this?

@scopsy testing is something needs to be done via nightly/alpha/beta. Before that I will need token as well

@scopsy
Copy link
Contributor

scopsy commented Jun 10, 2025

Awesome, than it looks good on my end 💪 Let's just test it with a nightly after merged to make sure everything works as expected. Also for the nightly, does it uses npm --tag ? to make sure it's not published as the latest version

- Introduced a new input parameter 'nightly' to the release workflow.
- Implemented logic to set a nightly version and handle nightly releases for versioning, changelog generation, and package publishing.
- Updated the publish step to tag nightly releases appropriately.
@merrcury merrcury merged commit e5e81f9 into next Jun 10, 2025
22 of 25 checks passed
@merrcury merrcury deleted the feat/releasepipeline branch June 10, 2025 11:28
bricehemery pushed a commit to jack-agency/novu that referenced this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants