Add Callgraph#185
Merged
Merged
Conversation
jubnzv
requested changes
Oct 18, 2024
Member
jubnzv
left a comment
jubnzv
left a comment
There was a problem hiding this comment.
I think, that's a good start. Please add an entry to CHANGELOG, and merge the master branch to your PR in order to simplify the test suite.
…n be access it later: cu.callgraph
…pdate constructor and make astStore public - Refactored `getFunctionName` to use a switch statement for better type safety. - Introduced `forEachExpression` helper function to handle expression processing recursively and improve code maintainability. - Updated constructor to remove `astStore` and pass it via the `build()` method, while making `astStore` a public property. - Updated Ir constructor add CallGraph - Remove from git .dot output file
jubnzv
reviewed
Oct 18, 2024
jubnzv
reviewed
Oct 18, 2024
jubnzv
reviewed
Oct 18, 2024
jubnzv
reviewed
Oct 18, 2024
jubnzv
requested changes
Oct 19, 2024
Member
jubnzv
left a comment
jubnzv
left a comment
There was a problem hiding this comment.
It is much better now. We need to:
- update the changelog
- introduce some tests in
test/tactIR.spec.ts - write a separate tool to dump the callgraph in the supported formats
Add tests. create Dump callgraph ( in detectors can add this line ( DumpCallGraph.run(cu); )
jubnzv
requested changes
Oct 20, 2024
Remake DumpCallgraph similar other dumps tool.
jubnzv
requested changes
Nov 4, 2024
jubnzv
reviewed
Nov 6, 2024
Member
jubnzv
left a comment
jubnzv
left a comment
There was a problem hiding this comment.
Overall looks good. Let's fix minor issues before merging it.
Member
|
We also need an entry in |
jubnzv
reviewed
Nov 6, 2024
Co-authored-by: Georgiy Komarov <jubnzv@gmail.com>
Co-authored-by: Georgiy Komarov <jubnzv@gmail.com>
Co-authored-by: Georgiy Komarov <jubnzv@gmail.com>
Co-authored-by: Georgiy Komarov <jubnzv@gmail.com>
Co-authored-by: Georgiy Komarov <jubnzv@gmail.com>
Co-authored-by: Georgiy Komarov <jubnzv@gmail.com>
Co-authored-by: Georgiy Komarov <jubnzv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91
CHANGELOG.mdyarn test-all