Fix bigint issue in DatabaseHandler: select returned bigint which cau… #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The bug was: If species had an existing value of body mass (not null), and it was changed, the DatabaseHandler.select was used by WriteHandler to fetch the old values for logging purposes - it returned a BigInt from MariaDB instead of number. This wasn't a problem otherwise, but there was a debug log that JSON-stringified the values, causing a bug because JSON.stringify can't handle bigints. I previously thought bigint was a prisma issue but apparently it's more mariadb specific. |
…sed issue on debug log of oldValue, and could possibly cause issues in future. Not 100% sure of how good the solution is, so keep an eye on it.
iritmaximus
force-pushed
the
writeFix
branch
from
3250416 to
7624df4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sed issue on debug log of oldValue, and could possibly cause issues in future.
Not 100% sure of how good the solution is, so keep an eye on it.