Skip to content

Conversation

@iritmaximus
Copy link
Collaborator

Api-tests now reset the database utilizing jest's beforeAll.

Copy link
Collaborator

@EeroAnt EeroAnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good, but could you explain if it's necessary for docker-compose.dev.yml needs test_data in volumes? If that's intended then I can approve

@iritmaximus
Copy link
Collaborator Author

That is intended. The reset happens by executing the test_data/sqlfiles so they are required. The sqlfiles are added through the docker-compose because if we added them to the backend/Dockerfile, then prod would also get the file which is not great.

Copy link
Collaborator

@EeroAnt EeroAnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EeroAnt EeroAnt merged commit 003216e into main Sep 26, 2024
@EeroAnt EeroAnt deleted the api-tests-db-reset branch September 26, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants