Fix time unit validator issue #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deeroil
force-pushed
the
fix-time-unit-validator-issue
branch
from
d9aca18 to
7af44b5
Compare
Deeroil
approved these changes
Oct 16, 2024
Collaborator
Deeroil
left a comment
Deeroil
left a comment
There was a problem hiding this comment.
Tested the validators and they seem to work / LGTM :D
This was
linked to
issues
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new editingComponent dedicated to Time bound selection, because I don't know how to get this to work otherwise. Also added a new optional function to validators to run any function you want to when validating